Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX CHORE] fix native-class use by eliminating use of Ember.Error #5753

Closed
wants to merge 4 commits into from
Closed

[BUGFIX CHORE] fix native-class use by eliminating use of Ember.Error #5753

wants to merge 4 commits into from

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Nov 20, 2018 •
edited
Loading

resolves #5752

Unfortunately our Error classes are fully public API (including instantiating them). I've opened up an RFC issue to discuss migrating us away from this pattern. emberjs/rfcs#402

@runspired runspired mentioned this pull request Nov 20, 2018
Closed
@runspired runspired added the code-review Tracks PRs that require a code-review label Nov 20, 2018
rwjblue
rwjblue previously approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but we really should move away from this when we can.

@runspired runspired removed the code-review Tracks PRs that require a code-review label Nov 21, 2018
@runspired
Copy link
Contributor Author

Failing 2.18 for run-loop issues (easy test fix) and ember beta/canary for unknown reasons.

@runspired runspired dismissed rwjblue’s stale review November 22, 2018 07:24

changes have happened and we need to continue investigating direction

@runspired runspired added concept-review Tracks PRs that introduce new concepts that need reviewed for discussion code-review Tracks PRs that require a code-review labels Nov 22, 2018
@runspired
Copy link
Contributor Author

We resolved this by reverting the change from function to class based definition of EmberError upstream.

@runspired runspired closed this Nov 28, 2018
@runspired runspired deleted the fix-native branch April 1, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@krisselden krisselden Awaiting requested review from krisselden

Assignees
No one assigned
Labels
code-review Tracks PRs that require a code-review concept-review Tracks PRs that introduce new concepts that need reviewed for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class constructor EmberError cannot be invoked without 'new'
2 participants
@runspired @rwjblue